test: Try fix a flaky test #2719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 123 123
Lines 22670 22670
=====================================
Hits 17986 17986
Misses 4684 4684 ☔ View full report in Codecov by Sentry. |
Member
Yes, I also suspected that. But I don't understand why it is not consistent. |
lalitb
approved these changes
Feb 26, 2025
Member
Author
next time it fails, we'll have the LogRecord in console logs. That should give some hint. (or this fix works and we never see failure again 🤣 ) |
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally seeing this failing in CI. I suspect it maybe capturing OTel's own logs. A quick fix is to filter for Error and above, so OTel Logs are unlikely to be captured. A more robust fix might be needed in the future, but this should unblock hopefully!